Repository navigation
Play the sound a console sends as its own message - #20
Merged
Merged
Conversation
The console sends each span's sound when its clock reaches the span, as a
message of its own ({"sound", "rate", "start"}), and the span's clock
after it. The scan's handler played sound only from a clock message, so
it played none.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since pulserver/pulserver#239, the console sends each span's sound as a message of its own,
{"sound", "rate", "start"}, when its clock reaches the span. The span's clock follows in a separate message. MaRGE played sound only when it came inside a clock message, so a scan now plays none. The browser suite catches this:test_a_scan_of_marges_protocol_plays_its_sound_and_returns_its_reconstructionfails with 0 s played against a 12 s clock, on #19 and on any PR built against pulserver's current main.The scan's handler now plays any message carrying
sound, and shows any message carryingclock.Test plan
tests/test_pulserver_console.py: the sound test streams the console's two messages (31 passed)#19's browser check should pass on a re-run once this is merged.
🤖 Generated with Claude Code